fix(release): resolve Windows Bash via PATH - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just 1.40.0 resolves the Windows
[script("bash", ...)]interpreter toC:\Windows\System32\bash.exe, the WSL launcher, instead of the Git Bash executable earlier onPATH. This is the command-resolution bug tracked in casey/just#2947 and fixed by casey/just#3160. Just 1.48.0 is the first release containing that fix.This updates the Hermit package and GitHub Actions pins to Just 1.48.0. It also removes
JUST_UNSTABLE; the script recipe attribute used byrelease-write-provenanceis stable in this version.With Git Bash selected,
write-provenance.shmust usesha256sumrather than assuming macOS'sshasumis installed. The script now selectsshasum -a 256when available, falls back tosha256sum, and exits with an explicit error when neither tool exists.Validated with:
just release-scripts-test(83 tests)just checkjust fmt-checkjust tauri-checkjust clippybin/hermit validate env .